Always return a promise on functions that don't always have an explic…

…it return and inlineHelpers is set
rpetrich · May 25, 2019 · eca3a59 · eca3a59
1 parent ce67368
commit eca3a59
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/async-to-promises.ts b/async-to-promises.ts
@@ -3417,7 +3417,11 @@ export default function({ types, template, traverse, transformFromAst, version }
 						const inlineHelpers = readConfigKey(this.opts, "inlineHelpers");
 						const canThrow = checkForErrorsAndRewriteReturns(bodyPath, this, inlineHelpers);
 						if (inlineHelpers && !pathsReturnOrThrowCurrentNodes(bodyPath).all) {
-							path.node.body.body.push(types.returnStatement());
+							if (inlineHelpers) {
+								path.node.body.body.push(types.returnStatement(types.callExpression(promiseResolve(), [])));
+							} else {
+								path.node.body.body.push(types.returnStatement());
+							}
 						}
 						if (canThrow) {
 							if (inlineHelpers) {

diff --git a/tests/default argument pattern/inlined.js b/tests/default argument pattern/inlined.js