Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "super" in class fields #3511

Merged
merged 2 commits into from Apr 22, 2020
Merged

Support "super" in class fields #3511

merged 2 commits into from Apr 22, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3505

Description

This bumps our fork of the corresponding package to support "super" in class fields

@rollup-bot
Copy link
Collaborator

rollup-bot commented Apr 22, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#super-in-class-fields

or load it into the REPL:
https://rollupjs.org/repl/?circleci=10678

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #3511 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3511   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         176      176           
  Lines        5984     5984           
  Branches     1762     1762           
=======================================
  Hits         5752     5752           
  Misses        118      118           
  Partials      114      114           
Impacted Files Coverage Δ
cli/run/loadConfigFile.ts 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65bae1...3c25bb5. Read the comment docs.

@lukastaegert lukastaegert merged commit 0d352bf into master Apr 22, 2020
@lukastaegert lukastaegert deleted the super-in-class-fields branch April 22, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup class fields error: 'super' keyword outside a method
2 participants