Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ban emitFile via absolute paths on Windows OS #3509

Merged
merged 2 commits into from Apr 22, 2020

Conversation

SASUKE40
Copy link
Contributor

@SASUKE40 SASUKE40 commented Apr 22, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The use of absolute paths to generate files via this.emitFile is allowed on Windows OS, which is inconsistent with other OS.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #3509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3509   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         176      176           
  Lines        5984     5984           
  Branches     1762     1762           
=======================================
  Hits         5752     5752           
  Misses        118      118           
  Partials      114      114           
Impacted Files Coverage Δ
src/utils/relativeId.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d352bf...c6df937. Read the comment docs.

@SASUKE40 SASUKE40 force-pushed the 20200422-fix-windows-emitFile branch from 4404073 to 59dbcbd Compare April 22, 2020 04:09
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@lukastaegert lukastaegert merged commit bd2973a into rollup:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants