Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect output.paths in dynamic imports #3508

Merged
merged 1 commit into from Apr 21, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3464

Description

This will make sure that both static and dynamic imports will respect the paths option.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3436-dynamic-import-paths

or load it into the REPL:
https://rollupjs.org/repl/?circleci=10632

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #3508 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3508   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         176      176           
  Lines        5983     5983           
  Branches     1761     1761           
=======================================
  Hits         5751     5751           
  Misses        118      118           
  Partials      114      114           
Impacted Files Coverage Δ
src/Chunk.ts 99.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437934e...65d947d. Read the comment docs.

@lukastaegert lukastaegert merged commit 1916b6d into master Apr 21, 2020
@lukastaegert lukastaegert deleted the gh-3436-dynamic-import-paths branch April 21, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output.paths w/ dynamic imports
2 participants