Ensure --watch mode exits correctly when stdin is closed. #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary when rollup is used as the front end for an Elixir Phoenix application. In dev mode, the phoenix watchers run the rollup command as a child process and the underlying erlang port mechanism assumes that the child process closes when the parent stdin is closed. Without this fix the old zombie processes never close and accumulate as you stop and start in development mode. This was discussed and fixed in 2017 in the original rollup-watcher repository: * rollup/rollup-watch#30 (comment) * https://github.com/rollup/rollup-watch/pull/57/files It appears to then have been removed as a side effect of another change * rollup#2410 Finally, was requested back in a PR that never got merged because of some doubt around the need to hide it behind a CLI flag * https://github.com/rollup/rollup/pull/2653/files For reference, webpack implements this hidden behind the --watch-stdin CLI flag.
Codecov Report
@@ Coverage Diff @@
## master #3493 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 175 175
Lines 5955 5956 +1
Branches 1752 1752
=======================================
+ Hits 5722 5723 +1
Misses 118 118
Partials 115 115
Continue to review full report at Codecov.
|
lukastaegert
approved these changes
Apr 12, 2020
|
Thank you for adding the test! Great work, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR ensures that the
rollup --watchprocess exits correctly when stdin is closed by the parent process.This is necessary when rollup is used as the front end for an Elixir Phoenix application. In dev mode, the phoenix watchers run the rollup command as a child process and the underlying erlang port mechanism assumes that the child process closes when the parent stdin is closed. Without this fix the old zombie processes never close and accumulate as you stop and start in development mode.
This was discussed and fixed in 2017 in the original rollup-watcher repository:
rollup --watchrollup-watch#30 (comment)It appears to then have been removed as a side effect of another change
Finally, was requested back in a PR that never got merged because of some doubt around the need to hide it behind a CLI flag
For reference, webpack implements this hidden behind the --watch-stdin CLI flag.