Deconflict global variables used inside format-specific code #2880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2853
Description
The original issue was that variables named
module
would shadow themodule
variable of the SystemJS wrapper. This is a much more general solution that includes the following improvements:import.meta.url
or asset/chunk URLs are protected from being shadowed by renaming any conflicting variablesexports
andmodule
parameters of the SystemJS wrapper if they are not neededrequire.toUrl
instead ofmodule.uri
+ string concatenation (@surma will probably not like this as this means his AMD loader might need adustments again).