Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle member expressions in array patterns #2760

Merged
merged 3 commits into from Mar 20, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
#2750

Description

Honestly, I was not aware that you could do this:

const a = [1];
const b = {};
([a[1], b.value] = [8, 9]);
console.log(a); // [1, 8]
console.log(b); // {value: 9}

But as it seems, even the maintainers of the ESTree AST spec are struggling with this: estree/estree#162

This triggered an issue in SystemJS builds, which rely on a special method present on those nodes.

@lukastaegert lukastaegert merged commit 8166eb0 into master Mar 20, 2019
@lukastaegert lukastaegert deleted the gh-2750-debug-array-pattern branch March 20, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant