Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with reexporting default as default with {exports: named,… #2620

Merged

Conversation

Andarist
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no (in some weird scenario technically this can be breaking for somebody)

List any relevant issue numbers:

Description

Without this it hit this branch -

else exportBlock += `exports.${specifier.reexported}${_}=${_}${name};`;
and thus emitted invalid reexport.

Andarist added a commit to redux-saga/redux-saga that referenced this pull request Dec 30, 2018
Andarist added a commit to redux-saga/redux-saga that referenced this pull request Dec 30, 2018
… it (#1712)

* Move core source to scoped package, use "redux-saga" only as proxy to it

* Workaround for rollup/rollup#2620

* Use distinct filenames for redux-saga proxy package

* Add missing default reexport in redux-saga index.d.ts
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks a lot!

@lukastaegert lukastaegert merged commit f5364d9 into rollup:master Jan 3, 2019
@Andarist Andarist deleted the fix/reexport-default-as-default branch January 3, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants