Skip to content

Commit

Permalink
Ensure that types packages have star version ranges (#3143)
Browse files Browse the repository at this point in the history
  • Loading branch information
lukastaegert committed Oct 5, 2019
1 parent 0e51dfb commit ee6a8c0
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Expand Up @@ -31,7 +31,7 @@ jobs:
command: npm ci --ignore-scripts
- run:
name: Run linting.
command: npm run lint
command: npm run ci:lint
- run:
name: Run NPM Security Audit
command: npm run security
Expand Down
2 changes: 1 addition & 1 deletion LICENSE.md
Expand Up @@ -398,7 +398,7 @@ Repository: git://github.com/kamicane/require-relative.git
## rollup-pluginutils
License: MIT
By: Rich Harris
Repository: rollup/rollup-pluginutils
Repository: git+https://github.com/rollup/rollup-pluginutils.git

---------------------------------------

Expand Down
26 changes: 13 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions package.json
Expand Up @@ -12,7 +12,7 @@
"build": "shx rm -rf dist && git rev-parse HEAD > .commithash && rollup -c && shx cp src/rollup/types.d.ts dist/rollup.d.ts && shx chmod a+x dist/bin/rollup",
"build:test": "shx rm -rf dist && rollup -c --configTest && shx cp src/rollup/types.d.ts dist/rollup.d.ts && shx chmod a+x dist/bin/rollup",
"build:bootstrap": "dist/bin/rollup -c && shx cp src/rollup/types.d.ts dist/rollup.d.ts && shx chmod a+x dist/bin/rollup",
"ci:lint": "npm run lint:nofix && npm run security",
"ci:lint": "npm run lint:nofix",
"ci:test": "npm run build:test && npm run build:bootstrap && npm run test:all",
"ci:coverage": "npm run build:test && nyc --reporter lcovonly mocha && codecov",
"lint": "npm run lint:ts -- --fix && npm run lint:js -- --fix && npm run lint:markdown",
Expand All @@ -30,9 +30,10 @@
"pretest:typescript": "shx rm -rf test/typescript/dist && shx cp -r dist test/typescript/",
"security": "npm audit",
"test": "npm run test:all",
"test:all": "npm run test:only && npm run test:typescript && npm run test:leak",
"test:all": "npm run test:only && npm run test:typescript && npm run test:leak && npm run test:package",
"test:coverage": "nyc --reporter html mocha",
"test:leak": "cross-os test:leak:os",
"test:package": "node scripts/test-package.js",
"test:leak:os": {
"darwin": "npm run test:leak:nix",
"linux": "npm run test:leak:nix",
Expand Down Expand Up @@ -64,7 +65,7 @@
"homepage": "https://github.com/rollup/rollup",
"dependencies": {
"@types/estree": "*",
"@types/node": "^12.7.10",
"@types/node": "*",
"acorn": "^7.1.0"
},
"devDependencies": {
Expand All @@ -85,7 +86,7 @@
"es6-shim": "^0.35.5",
"eslint": "^6.5.1",
"eslint-plugin-import": "^2.18.2",
"execa": "^2.0.4",
"execa": "^2.0.5",
"fixturify": "^1.2.0",
"hash.js": "^1.1.7",
"husky": "^3.0.8",
Expand All @@ -104,7 +105,7 @@
"pretty-ms": "^5.0.0",
"require-relative": "^0.8.7",
"requirejs": "^2.3.6",
"rollup": "^1.22.0",
"rollup": "^1.23.0",
"rollup-plugin-alias": "^2.0.1",
"rollup-plugin-buble": "^0.19.8",
"rollup-plugin-commonjs": "^10.1.0",
Expand All @@ -123,7 +124,7 @@
"source-map-support": "^0.5.13",
"sourcemap-codec": "^1.4.6",
"systemjs": "^6.1.2",
"terser": "^4.3.4",
"terser": "^4.3.6",
"tslib": "^1.10.0",
"tslint": "^5.20.0",
"turbocolor": "^2.6.1",
Expand Down
7 changes: 7 additions & 0 deletions scripts/test-package.js
@@ -0,0 +1,7 @@
const pkg = require('../package.json');

for (const key of Object.keys((pkg.dependencies))) {
if (key.startsWith('@types') && pkg.dependencies[key] !== '*') {
throw new Error(`The dependency ${key} should have version range "*" but it was "${pkg.dependencies[key]}".`);
}
}

0 comments on commit ee6a8c0

Please sign in to comment.