Fix bind order in for-loops, resolves #2337 (#2338)

rollup · Jul 18, 2018 · be58bce · be58bce
1 parent 9c60723
commit be58bce
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/src/ast/nodes/ForInStatement.ts b/src/ast/nodes/ForInStatement.ts
@@ -20,8 +20,10 @@ export default class ForInStatement extends StatementBase {
 	body: StatementNode;
 
 	bind() {
-		super.bind();
+		this.left.bind();
 		this.left.deoptimizePath(EMPTY_PATH);
+		this.right.bind();
+		this.body.bind();
 	}
 
 	createScope(parentScope: Scope) {

diff --git a/src/ast/nodes/ForOfStatement.ts b/src/ast/nodes/ForOfStatement.ts
@@ -21,8 +21,10 @@ export default class ForOfStatement extends StatementBase {
 	await: boolean;
 
 	bind() {
-		super.bind();
+		this.left.bind();
 		this.left.deoptimizePath(EMPTY_PATH);
+		this.right.bind();
+		this.body.bind();
 	}
 
 	createScope(parentScope: Scope) {

diff --git a/test/function/samples/for-of-with-in-operator/_config.js b/test/function/samples/for-of-with-in-operator/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'handles using the in operator in the iterator of a for-of loop (#2337)'
+};
diff --git a/test/function/samples/for-of-with-in-operator/main.js b/test/function/samples/for-of-with-in-operator/main.js
@@ -0,0 +1,5 @@
+for (const foo of [{}]) {
+	if ('x' in foo) {
+		throw new Error('There should be no x');
+	}
+}