Set null prototype on namespace objects. (#3136)

* Give namespaces null prototype. * Fix snapshot tests. * Fix snapshot tests. * Fix formatting. * Fix formatting. * Fix formatting. * Fix tests.
rollup · Sep 26, 2019 · b8335db · b8335db
1 parent a1ec55c
commit b8335db
Show file tree

Hide file tree

Showing 76 changed files with 218 additions and 8 deletions.
diff --git a/src/ast/variables/NamespaceVariable.ts b/src/ast/variables/NamespaceVariable.ts
@@ -91,6 +91,8 @@ export default class NamespaceVariable extends Variable {
 			return `${t}${safeName}: ${original.getName()}`;
 		});
 
+		members.unshift(`${t}__proto__:${_}null`);
+
 		if (options.namespaceToStringTag) {
 			members.unshift(`${t}[Symbol.toStringTag]:${_}'Module'`);
 		}

diff --git a/...hunking-form/samples/dynamic-import-statically-imported-2/_expected/amd/generated-dep1.js b/...hunking-form/samples/dynamic-import-statically-imported-2/_expected/amd/generated-dep1.js
@@ -11,6 +11,7 @@ define(['exports'], function (exports) { 'use strict';
 	}
 
 	var dep1 = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		bar: bar
 	});
 

diff --git a/...hunking-form/samples/dynamic-import-statically-imported-2/_expected/cjs/generated-dep1.js b/...hunking-form/samples/dynamic-import-statically-imported-2/_expected/cjs/generated-dep1.js
@@ -11,6 +11,7 @@ function bar() {
 }
 
 var dep1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	bar: bar
 });
 

diff --git a/...chunking-form/samples/dynamic-import-statically-imported-2/_expected/es/generated-dep1.js b/...chunking-form/samples/dynamic-import-statically-imported-2/_expected/es/generated-dep1.js
@@ -9,6 +9,7 @@ function bar() {
 }
 
 var dep1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	bar: bar
 });
 

diff --git a/...king-form/samples/dynamic-import-statically-imported-2/_expected/system/generated-dep1.js b/...king-form/samples/dynamic-import-statically-imported-2/_expected/system/generated-dep1.js
@@ -19,6 +19,7 @@ System.register([], function (exports) {
 			}
 
 			var dep1 = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				bar: bar
 			});
 

diff --git a/.../chunking-form/samples/dynamic-import-statically-imported/_expected/amd/generated-dep1.js b/.../chunking-form/samples/dynamic-import-statically-imported/_expected/amd/generated-dep1.js
@@ -11,6 +11,7 @@ define(['exports'], function (exports) { 'use strict';
 	}
 
 	var dep1 = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		bar: bar
 	});
 

diff --git a/.../chunking-form/samples/dynamic-import-statically-imported/_expected/cjs/generated-dep1.js b/.../chunking-form/samples/dynamic-import-statically-imported/_expected/cjs/generated-dep1.js
@@ -11,6 +11,7 @@ function bar() {
 }
 
 var dep1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	bar: bar
 });
 

diff --git a/test/chunking-form/samples/dynamic-import-statically-imported/_expected/es/generated-dep1.js b/test/chunking-form/samples/dynamic-import-statically-imported/_expected/es/generated-dep1.js
@@ -9,6 +9,7 @@ function bar() {
 }
 
 var dep1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	bar: bar
 });
 

diff --git a/...unking-form/samples/dynamic-import-statically-imported/_expected/system/generated-dep1.js b/...unking-form/samples/dynamic-import-statically-imported/_expected/system/generated-dep1.js
@@ -19,6 +19,7 @@ System.register([], function (exports) {
 			}
 
 			var dep1 = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				bar: bar
 			});
 

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/amd/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/amd/generated-m1.js
@@ -3,6 +3,7 @@ define(['exports', './m2'], function (exports, m2) { 'use strict';
 
 
 	var ms = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		m2: m2
 	});
 

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/cjs/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/cjs/generated-m1.js
@@ -5,6 +5,7 @@ var m2 = require('./m2.js');
 
 
 var ms = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	m2: m2
 });
 

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/es/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/es/generated-m1.js
@@ -4,6 +4,7 @@ export { default as m } from './m2.js';
 
 
 var ms = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	m2: m2
 });
 

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/system/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/system/generated-m1.js
@@ -11,6 +11,7 @@ System.register(['./m2.js'], function (exports) {
 
 
 			var ms = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				m2: m2
 			});
 			exports('a', ms);

diff --git a/test/chunking-form/samples/namespace-object-import/_expected/amd/generated-main2.js b/test/chunking-form/samples/namespace-object-import/_expected/amd/generated-main2.js
@@ -4,6 +4,7 @@ define(['exports'], function (exports) { 'use strict';
 	var b = 'a';
 
 	var main2 = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		a: a,
 		b: b
 	});

diff --git a/test/chunking-form/samples/namespace-object-import/_expected/cjs/generated-main2.js b/test/chunking-form/samples/namespace-object-import/_expected/cjs/generated-main2.js
@@ -4,6 +4,7 @@ var a = 'a';
 var b = 'a';
 
 var main2 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	a: a,
 	b: b
 });

diff --git a/test/chunking-form/samples/namespace-object-import/_expected/es/generated-main2.js b/test/chunking-form/samples/namespace-object-import/_expected/es/generated-main2.js
@@ -2,6 +2,7 @@ var a = 'a';
 var b = 'a';
 
 var main2 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	a: a,
 	b: b
 });

diff --git a/test/chunking-form/samples/namespace-object-import/_expected/system/generated-main2.js b/test/chunking-form/samples/namespace-object-import/_expected/system/generated-main2.js
@@ -7,6 +7,7 @@ System.register([], function (exports) {
 			var b = exports('b', 'a');
 
 			var main2 = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				a: a,
 				b: b
 			});

diff --git a/test/chunking-form/samples/namespace-reexport-name-conflict/_expected/amd/generated-index.js b/test/chunking-form/samples/namespace-reexport-name-conflict/_expected/amd/generated-index.js
@@ -3,6 +3,7 @@ define(['exports', './generated-dep', 'external'], function (exports, dep, exter
 	console.log(external.reexported);
 
 	var lib = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		reexported: dep.reexported
 	});
 

diff --git a/test/chunking-form/samples/namespace-reexport-name-conflict/_expected/cjs/generated-index.js b/test/chunking-form/samples/namespace-reexport-name-conflict/_expected/cjs/generated-index.js
@@ -6,6 +6,7 @@ var external = require('external');
 console.log(external.reexported);
 
 var lib = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	reexported: dep.reexported
 });
 

diff --git a/test/chunking-form/samples/namespace-reexport-name-conflict/_expected/es/generated-index.js b/test/chunking-form/samples/namespace-reexport-name-conflict/_expected/es/generated-index.js
@@ -4,6 +4,7 @@ import { reexported } from 'external';
 console.log(reexported);
 
 var lib = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	reexported: reexported$1
 });
 

diff --git a/...hunking-form/samples/namespace-reexport-name-conflict/_expected/system/generated-index.js b/...hunking-form/samples/namespace-reexport-name-conflict/_expected/system/generated-index.js
@@ -12,6 +12,7 @@ System.register(['./generated-dep.js', 'external'], function (exports) {
 			console.log(reexported);
 
 			var lib = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				reexported: reexported$1
 			});
 			exports('l', lib);

diff --git a/test/chunking-form/samples/namespace-reexports/_expected/amd/generated-index.js b/test/chunking-form/samples/namespace-reexports/_expected/amd/generated-index.js
@@ -5,6 +5,7 @@ define(['exports', './hsl2hsv'], function (exports, hsl2hsv$1) { 'use strict';
 	console.log(hsl2hsv);
 
 	var lib = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		hsl2hsv: hsl2hsv$1.default
 	});
 

diff --git a/test/chunking-form/samples/namespace-reexports/_expected/cjs/generated-index.js b/test/chunking-form/samples/namespace-reexports/_expected/cjs/generated-index.js
@@ -7,6 +7,7 @@ var hsl2hsv = 'asdf';
 console.log(hsl2hsv);
 
 var lib = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	hsl2hsv: hsl2hsv$1.default
 });
 

diff --git a/test/chunking-form/samples/namespace-reexports/_expected/es/generated-index.js b/test/chunking-form/samples/namespace-reexports/_expected/es/generated-index.js
@@ -6,6 +6,7 @@ var hsl2hsv = 'asdf';
 console.log(hsl2hsv);
 
 var lib = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	hsl2hsv: hsl2hsv$1
 });
 

diff --git a/test/chunking-form/samples/namespace-reexports/_expected/system/generated-index.js b/test/chunking-form/samples/namespace-reexports/_expected/system/generated-index.js
@@ -13,6 +13,7 @@ System.register(['./hsl2hsv.js'], function (exports) {
 			console.log(hsl2hsv);
 
 			var lib = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				hsl2hsv: hsl2hsv$1
 			});
 			exports('l', lib);

diff --git a/test/form/samples/compact/_expected/amd.js b/test/form/samples/compact/_expected/amd.js
@@ -1,4 +1,4 @@
-define(['external'],function(x){'use strict';x=x&&x.hasOwnProperty('default')?x['default']:x;var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',get default(){return foo}});console.log(self);
+define(['external'],function(x){'use strict';x=x&&x.hasOwnProperty('default')?x['default']:x;var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',__proto__:null,get default(){return foo}});console.log(self);
 function foo () {
 	console.log( x );
 }

diff --git a/test/form/samples/compact/_expected/cjs.js b/test/form/samples/compact/_expected/cjs.js
@@ -1,4 +1,4 @@
-'use strict';function _interopDefault(e){return(e&&(typeof e==='object')&&'default'in e)?e['default']:e}var x=_interopDefault(require('external'));var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',get default(){return foo}});console.log(self);
+'use strict';function _interopDefault(e){return(e&&(typeof e==='object')&&'default'in e)?e['default']:e}var x=_interopDefault(require('external'));var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',__proto__:null,get default(){return foo}});console.log(self);
 function foo () {
 	console.log( x );
 }

diff --git a/test/form/samples/compact/_expected/es.js b/test/form/samples/compact/_expected/es.js
@@ -1,4 +1,4 @@
-import x from'external';var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',get default(){return foo}});console.log(self);
+import x from'external';var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',__proto__:null,get default(){return foo}});console.log(self);
 function foo () {
 	console.log( x );
 }

diff --git a/test/form/samples/compact/_expected/iife.js b/test/form/samples/compact/_expected/iife.js
@@ -1,4 +1,4 @@
-var foo=(function(x){'use strict';x=x&&x.hasOwnProperty('default')?x['default']:x;var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',get default(){return foo}});console.log(self);
+var foo=(function(x){'use strict';x=x&&x.hasOwnProperty('default')?x['default']:x;var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',__proto__:null,get default(){return foo}});console.log(self);
 function foo () {
 	console.log( x );
 }

diff --git a/test/form/samples/compact/_expected/system.js b/test/form/samples/compact/_expected/system.js
@@ -1,4 +1,4 @@
-System.register('foo',['external'],function(exports){'use strict';var x;return{setters:[function(module){x=module.default;}],execute:function(){exports('default',foo);var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',get default(){return foo}});console.log(self);
+System.register('foo',['external'],function(exports){'use strict';var x;return{setters:[function(module){x=module.default;}],execute:function(){exports('default',foo);var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',__proto__:null,get default(){return foo}});console.log(self);
 function foo () {
 	console.log( x );
 }

diff --git a/test/form/samples/compact/_expected/umd.js b/test/form/samples/compact/_expected/umd.js
@@ -1,4 +1,4 @@
-(function(g,f){typeof exports==='object'&&typeof module!=='undefined'?module.exports=f(require('external')):typeof define==='function'&&define.amd?define(['external'],f):(g=g||self,g.foo=f(g.x));}(this,function(x){'use strict';x=x&&x.hasOwnProperty('default')?x['default']:x;var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',get default(){return foo}});console.log(self);
+(function(g,f){typeof exports==='object'&&typeof module!=='undefined'?module.exports=f(require('external')):typeof define==='function'&&define.amd?define(['external'],f):(g=g||self,g.foo=f(g.x));}(this,function(x){'use strict';x=x&&x.hasOwnProperty('default')?x['default']:x;var self=/*#__PURE__*/Object.freeze({[Symbol.toStringTag]:'Module',__proto__:null,get default(){return foo}});console.log(self);
 function foo () {
 	console.log( x );
 }

diff --git a/test/form/samples/dynamic-import-inlining/_expected.js b/test/form/samples/dynamic-import-inlining/_expected.js
@@ -4,6 +4,7 @@ Promise.resolve().then(function () { return foo$1; });
 const foo = 1;
 
 var foo$1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	foo: foo
 });
 

diff --git a/test/form/samples/freeze/_expected/amd.js b/test/form/samples/freeze/_expected/amd.js
@@ -4,6 +4,7 @@ define(['exports'], function (exports) { 'use strict';
 	const bar = 2;
 
 	var namespace = ({
+		__proto__: null,
 		foo: foo,
 		bar: bar
 	});

diff --git a/test/form/samples/freeze/_expected/cjs.js b/test/form/samples/freeze/_expected/cjs.js
@@ -6,6 +6,7 @@ const foo = 1;
 const bar = 2;
 
 var namespace = ({
+	__proto__: null,
 	foo: foo,
 	bar: bar
 });

diff --git a/test/form/samples/freeze/_expected/es.js b/test/form/samples/freeze/_expected/es.js
@@ -2,6 +2,7 @@ const foo = 1;
 const bar = 2;
 
 var namespace = ({
+	__proto__: null,
 	foo: foo,
 	bar: bar
 });

diff --git a/test/form/samples/freeze/_expected/iife.js b/test/form/samples/freeze/_expected/iife.js
@@ -5,6 +5,7 @@ var myBundle = (function (exports) {
 	const bar = 2;
 
 	var namespace = ({
+		__proto__: null,
 		foo: foo,
 		bar: bar
 	});

diff --git a/test/form/samples/freeze/_expected/system.js b/test/form/samples/freeze/_expected/system.js
@@ -7,6 +7,7 @@ System.register('myBundle', [], function (exports) {
 			const bar = 2;
 
 			var namespace = ({
+				__proto__: null,
 				foo: foo,
 				bar: bar
 			});

diff --git a/test/form/samples/freeze/_expected/umd.js b/test/form/samples/freeze/_expected/umd.js
@@ -8,6 +8,7 @@
 	const bar = 2;
 
 	var namespace = ({
+		__proto__: null,
 		foo: foo,
 		bar: bar
 	});

diff --git a/test/form/samples/namespace-object-import/_expected/amd.js b/test/form/samples/namespace-object-import/_expected/amd.js
@@ -3,6 +3,7 @@ define(function () { 'use strict';
 	var dep = "default";
 
 	var dep$1 = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		'default': dep
 	});
 

diff --git a/test/form/samples/namespace-object-import/_expected/cjs.js b/test/form/samples/namespace-object-import/_expected/cjs.js
@@ -3,6 +3,7 @@
 var dep = "default";
 
 var dep$1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	'default': dep
 });
 

diff --git a/test/form/samples/namespace-object-import/_expected/es.js b/test/form/samples/namespace-object-import/_expected/es.js
@@ -1,6 +1,7 @@
 var dep = "default";
 
 var dep$1 = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	'default': dep
 });
 

diff --git a/test/form/samples/namespace-object-import/_expected/iife.js b/test/form/samples/namespace-object-import/_expected/iife.js
@@ -4,6 +4,7 @@
 	var dep = "default";
 
 	var dep$1 = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		'default': dep
 	});
 

diff --git a/test/form/samples/namespace-object-import/_expected/system.js b/test/form/samples/namespace-object-import/_expected/system.js
@@ -6,6 +6,7 @@ System.register([], function () {
 			var dep = "default";
 
 			var dep$1 = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				'default': dep
 			});
 

diff --git a/test/form/samples/namespace-object-import/_expected/umd.js b/test/form/samples/namespace-object-import/_expected/umd.js
@@ -6,6 +6,7 @@
 	var dep = "default";
 
 	var dep$1 = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		'default': dep
 	});
 

diff --git a/test/form/samples/namespace-self-import/_expected/amd.js b/test/form/samples/namespace-self-import/_expected/amd.js
@@ -1,6 +1,7 @@
 define(['exports'], function (exports) { 'use strict';
 
 	var self = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		get p () { return p; }
 	});
 

diff --git a/test/form/samples/namespace-self-import/_expected/cjs.js b/test/form/samples/namespace-self-import/_expected/cjs.js
@@ -3,6 +3,7 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var self = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	get p () { return p; }
 });
 

diff --git a/test/form/samples/namespace-self-import/_expected/es.js b/test/form/samples/namespace-self-import/_expected/es.js
@@ -1,4 +1,5 @@
 var self = /*#__PURE__*/Object.freeze({
+	__proto__: null,
 	get p () { return p; }
 });
 

diff --git a/test/form/samples/namespace-self-import/_expected/iife.js b/test/form/samples/namespace-self-import/_expected/iife.js
@@ -2,6 +2,7 @@ var iife = (function (exports) {
 	'use strict';
 
 	var self = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		get p () { return p; }
 	});
 

diff --git a/test/form/samples/namespace-self-import/_expected/system.js b/test/form/samples/namespace-self-import/_expected/system.js
@@ -4,6 +4,7 @@ System.register('iife', [], function (exports) {
 		execute: function () {
 
 			var self = /*#__PURE__*/Object.freeze({
+				__proto__: null,
 				get p () { return p; }
 			});
 

diff --git a/test/form/samples/namespace-self-import/_expected/umd.js b/test/form/samples/namespace-self-import/_expected/umd.js
@@ -5,6 +5,7 @@
 }(this, function (exports) { 'use strict';
 
 	var self = /*#__PURE__*/Object.freeze({
+		__proto__: null,
 		get p () { return p; }
 	});
 

diff --git a/test/form/samples/namespace-tostringtag/_expected/amd.js b/test/form/samples/namespace-tostringtag/_expected/amd.js
@@ -2,6 +2,7 @@ define(['exports'], function (exports) { 'use strict';
 
 	var self = /*#__PURE__*/Object.freeze({
 		[Symbol.toStringTag]: 'Module',
+		__proto__: null,
 		get p () { return p; }
 	});