Skip to content

Commit

Permalink
* Forgot to forward the arguments for .render(code, es)
Browse files Browse the repository at this point in the history
* Resolve #1708
  • Loading branch information
lukastaegert committed Nov 10, 2017
1 parent 3224778 commit b5081ba
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/ast/nodes/SequenceExpression.js
Expand Up @@ -41,7 +41,7 @@ export default class SequenceExpression extends Node {
} else {
let previousEnd = this.start;
for ( const expression of included ) {
expression.render();
expression.render( code, es );
code.remove( previousEnd, expression.start );
code.appendLeft( expression.end, ', ' );
previousEnd = expression.end;
Expand Down
3 changes: 3 additions & 0 deletions test/form/samples/sequence-expression/_expected/amd.js
Expand Up @@ -17,4 +17,7 @@ define(function () { 'use strict';
// should keep f import
var e = (foo$1());

// should properly render complex sub-expressions
var g = ((() => {console.log(foo$1());})(), 1);

});
3 changes: 3 additions & 0 deletions test/form/samples/sequence-expression/_expected/cjs.js
Expand Up @@ -16,3 +16,6 @@ console.log(d);
// should infer value
// should keep f import
var e = (foo$1());

// should properly render complex sub-expressions
var g = ((() => {console.log(foo$1());})(), 1);
3 changes: 3 additions & 0 deletions test/form/samples/sequence-expression/_expected/es.js
Expand Up @@ -14,3 +14,6 @@ console.log(d);
// should infer value
// should keep f import
var e = (foo$1());

// should properly render complex sub-expressions
var g = ((() => {console.log(foo$1());})(), 1);
3 changes: 3 additions & 0 deletions test/form/samples/sequence-expression/_expected/iife.js
Expand Up @@ -18,4 +18,7 @@
// should keep f import
var e = (foo$1());

// should properly render complex sub-expressions
var g = ((() => {console.log(foo$1());})(), 1);

}());
3 changes: 3 additions & 0 deletions test/form/samples/sequence-expression/_expected/umd.js
Expand Up @@ -21,4 +21,7 @@
// should keep f import
var e = (foo$1());

// should properly render complex sub-expressions
var g = ((() => {console.log(foo$1());})(), 1);

})));
3 changes: 3 additions & 0 deletions test/form/samples/sequence-expression/main.js
Expand Up @@ -18,3 +18,6 @@ if ((1, 2) !== 2) {

// should keep f import
var e = (0, f.foo());

// should properly render complex sub-expressions
var g = ((() => {})(), (() => {console.log(f.foo())})(), 1);

0 comments on commit b5081ba

Please sign in to comment.