less cryptic error if entry module is external (#1264)

rollup · Jul 9, 2017 · b26ac1d · b26ac1d
1 parent dcda451
commit b26ac1d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/src/Bundle.js b/src/Bundle.js
@@ -122,6 +122,13 @@ export default class Bundle {
 		// of the entry module's dependencies
 		return this.resolveId( this.entry, undefined )
 			.then( id => {
+				if ( id === false ) {
+					error({
+						code: 'UNRESOLVED_ENTRY',
+						message: `Entry module cannot be external`
+					});
+				}
+
 				if ( id == null ) {
 					error({
 						code: 'UNRESOLVED_ENTRY',

diff --git a/test/function/external-function-always-true/_config.js b/test/function/external-function-always-true/_config.js
@@ -0,0 +1,10 @@
+module.exports = {
+	description: 'prints useful error if external returns true for entry (#1264)',
+	options: {
+		external: id => true
+	},
+	error: {
+		code: 'UNRESOLVED_ENTRY',
+		message: 'Entry module cannot be external'
+	}
+};
diff --git a/test/function/external-function-always-true/main.js b/test/function/external-function-always-true/main.js
@@ -0,0 +1,2 @@
+import ext from 'external';
+assert.equal( ext, 42 );