Get rid of getEntryModules

rollup · May 9, 2020 · 8f66e6e · 8f66e6e
1 parent f71ac84
commit 8f66e6e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/src/ModuleLoader.ts b/src/ModuleLoader.ts
@@ -208,8 +208,6 @@ export class ModuleLoader {
 
 	assignManualChunks(getManualChunk: GetManualChunk) {
 		const manualChunksApi = {
-			getEntryModuleIds: () =>
-				this.indexedEntryModules.map(({ module: { id } }) => id)[Symbol.iterator](),
 			getModuleIds: () => this.modulesById.keys(),
 			getModuleInfo: this.graph.getModuleInfo
 		};

diff --git a/src/rollup/types.d.ts b/src/rollup/types.d.ts
@@ -443,7 +443,6 @@ export interface TreeshakingOptions {
 	unknownGlobalSideEffects?: boolean;
 }
 interface GetManualChunkApi {
-	getEntryModuleIds: () => IterableIterator<string>;
 	getModuleIds: () => IterableIterator<string>;
 	getModuleInfo: GetModuleInfo;
 }

diff --git a/src/utils/PluginContext.ts b/src/utils/PluginContext.ts
@@ -133,6 +133,7 @@ export function getPluginContexts(
 			meta: {
 				rollupVersion
 			},
+			// TODO Lukas also add getmoduleids and soft-deprecate
 			get moduleIds() {
 				return graph.moduleById.keys();
 			},

diff --git a/test/function/samples/manual-chunks-info/_config.js b/test/function/samples/manual-chunks-info/_config.js
@@ -9,8 +9,7 @@ module.exports = {
 	description: 'provides additional chunk information to a manualChunks function',
 	options: {
 		external: 'external',
-		manualChunks(id, { getEntryModuleIds, getModuleIds, getModuleInfo }) {
-			assert.deepStrictEqual([...getEntryModuleIds()], [getId('main')]);
+		manualChunks(id, { getModuleIds, getModuleInfo }) {
 			assert.deepStrictEqual(
 				[...getModuleIds()],
 				[getId('main'), 'external', getId('lib'), getId('dynamic')]