Merge pull request #1311 from kzc/1273

put parens around sequences if conditional simplified

package.json

@@ -44,7 +44,7 @@
   },
   "homepage": "https://github.com/rollup/rollup",
   "devDependencies": {
-    "acorn": "^4.0.1",
+    "acorn": "4.0.4",
     "buble": "^0.15.1",
     "chalk": "^1.1.3",
     "codecov.io": "^0.1.6",

src/ast/nodes/ConditionalExpression.js

@@ -54,10 +54,18 @@ export default class ConditionalExpression extends Node {
 			else if ( this.testValue ) {
 				code.remove( this.start, this.consequent.start );
 				code.remove( this.consequent.end, this.end );
+				if ( this.consequent.type === 'SequenceExpression' ) {
+					code.insertRight( this.consequent.start, '(' );
+					code.insertLeft( this.consequent.end, ')' );
+				}
 				this.consequent.render( code, es );
 			} else {
 				code.remove( this.start, this.alternate.start );
 				code.remove( this.alternate.end, this.end );
+				if ( this.alternate.type === 'SequenceExpression' ) {
+					code.insertRight( this.alternate.start, '(' );
+					code.insertLeft( this.alternate.end, ')' );
+				}
 				this.alternate.render( code, es );
 			}
 		}

test/form/conditional-put-parens-around-sequence/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'put parens around sequences if conditional simplified (#1311)'
+};

test/form/conditional-put-parens-around-sequence/_expected/amd.js

@@ -0,0 +1,10 @@
+define(function () { 'use strict';
+
+	var a = (1, 2, 3 );
+	var b = (4, 5, 6 );
+	foo( a, b );
+
+	// verify works with no whitespace
+	bar((1,2),(7,8));
+
+});

test/form/conditional-put-parens-around-sequence/_expected/cjs.js

@@ -0,0 +1,8 @@
+'use strict';
+
+var a = (1, 2, 3 );
+var b = (4, 5, 6 );
+foo( a, b );
+
+// verify works with no whitespace
+bar((1,2),(7,8));

test/form/conditional-put-parens-around-sequence/_expected/es.js

@@ -0,0 +1,6 @@
+var a = (1, 2, 3 );
+var b = (4, 5, 6 );
+foo( a, b );
+
+// verify works with no whitespace
+bar((1,2),(7,8));

test/form/conditional-put-parens-around-sequence/_expected/iife.js

@@ -0,0 +1,11 @@
+(function () {
+	'use strict';
+
+	var a = (1, 2, 3 );
+	var b = (4, 5, 6 );
+	foo( a, b );
+
+	// verify works with no whitespace
+	bar((1,2),(7,8));
+
+}());

test/form/conditional-put-parens-around-sequence/_expected/umd.js

@@ -0,0 +1,14 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(factory());
+}(this, (function () { 'use strict';
+
+	var a = (1, 2, 3 );
+	var b = (4, 5, 6 );
+	foo( a, b );
+
+	// verify works with no whitespace
+	bar((1,2),(7,8));
+
+})));

test/form/conditional-put-parens-around-sequence/main.js

@@ -0,0 +1,6 @@
+var a = true  ? ( 1, 2, 3 ) : ( 4, 5, 6 );
+var b = false ? ( 1, 2, 3 ) : ( 4, 5, 6 );
+foo( a, b );
+
+// verify works with no whitespace
+bar(true?(1,2):(3,4),false?(5,6):(7,8));