Merge pull request #1204 from rollup/gh-1198

ignore var inits in dead branches
rollup · Dec 30, 2016 · 38bb9d9 · 38bb9d9
2 parents 11a2830 + d1d667f
commit 38bb9d9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/ast/nodes/IfStatement.js b/src/ast/nodes/IfStatement.js
@@ -17,9 +17,10 @@ function handleVarDeclarations ( node, scope ) {
 
 	function visit ( node ) {
 		if ( node.type === 'VariableDeclaration' && node.kind === 'var' ) {
-			node.initialise( scope );
-
 			node.declarations.forEach( declarator => {
+				declarator.init = null;
+				declarator.initialise( scope );
+
 				extractNames( declarator.id ).forEach( name => {
 					if ( !~hoistedVars.indexOf( name ) ) hoistedVars.push( name );
 				});

diff --git a/test/function/vars-with-init-in-dead-branch/_config.js b/test/function/vars-with-init-in-dead-branch/_config.js
@@ -0,0 +1,9 @@
+module.exports = {
+	description: 'handles vars with init in dead branch (#1198)',
+	warnings: [
+		{
+			code: 'EMPTY_BUNDLE',
+			message: 'Generated an empty bundle'
+		}
+	]
+};
diff --git a/test/function/vars-with-init-in-dead-branch/main.js b/test/function/vars-with-init-in-dead-branch/main.js
@@ -0,0 +1,4 @@
+if ( false ) {
+	var foo = [];
+	var bar = foo.concat( 'x' );
+}