fix: plugin name in template string (#2470)

* Fix template string * Add test for plugin name
rollup · Sep 21, 2018 · 2d2ae21 · 2d2ae21
1 parent d8a4d7b
commit 2d2ae21
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/utils/pluginDriver.ts b/src/utils/pluginDriver.ts
@@ -343,7 +343,7 @@ function uncacheablePluginError(pluginName: string) {
 		error({
 			code: 'DUPLICATE_PLUGIN_NAME',
 			message:
-				'The plugin name ${pluginName} is being used twice in the same build. Plugin names must be distinct or provide a cacheKey (please post an issue to the plugin if you are a plugin user).'
+				`The plugin name ${pluginName} is being used twice in the same build. Plugin names must be distinct or provide a cacheKey (please post an issue to the plugin if you are a plugin user).`
 		});
 }
 

diff --git a/test/hooks/index.js b/test/hooks/index.js
@@ -822,19 +822,20 @@ module.exports = input;
 				]
 			})
 			.then(() => {
+				const name = 'MyTestPluginName';
 				return rollup
 					.rollup({
 						input: 'input',
 						plugins: [
 							loader({ input: `alert('hello')` }),
 							{
-								name: 'a',
+								name: name,
 								buildStart() {
 									this.cache.set('asdf', 'asdf');
 								}
 							},
 							{
-								name: 'a',
+								name: name,
 								buildStart() {
 									this.cache.set('asdf', 'asdf');
 								}
@@ -844,6 +845,7 @@ module.exports = input;
 					.catch(err => {
 						assert.equal(err.code, 'PLUGIN_ERROR');
 						assert.equal(err.pluginCode, 'DUPLICATE_PLUGIN_NAME');
+						assert.equal(err.message.includes(name), true)
 					});
 			});
 	});