always disable globbing (#2432)

* always disable globbing

* add a test

* Update changelog

CHANGELOG.md

@@ -1,5 +1,9 @@
 # rollup changelog
 
+## 0.65.1
+*unreleased*
+* Prevent globbing when using chokidar ([#2432](https://github.com/rollup/rollup/pull/2432))
+
 ## 0.65.0
 *2018-08-25*
 * Refactor and unify plugin system ([#2382](https://github.com/rollup/rollup/pull/2382))

src/watch/index.ts

@@ -130,7 +130,8 @@ export class Task {
 		if (chokidarOptions) {
 			chokidarOptions = {
 				...(chokidarOptions === true ? {} : chokidarOptions),
-				ignoreInitial: true
+				ignoreInitial: true,
+				disableGlobbing: true
 			};
 		}
 

test/watch/index.js

@@ -954,5 +954,39 @@ describe('rollup.watch', () => {
 					]);
 				});
 		});
+
+		it('treats filenames literally, not as globs', () => {
+			return sander
+				.copydir('test/watch/samples/non-glob')
+				.to('test/_tmp/input')
+				.then(() => {
+					const watcher = rollup.watch({
+						input: 'test/_tmp/input/main.js',
+						output: {
+							file: 'test/_tmp/output/bundle.js',
+							format: 'cjs'
+						},
+						watch: { chokidar }
+					});
+
+					return sequence(watcher, [
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.equal(run('../_tmp/output/bundle.js'), 42);
+							sander.writeFileSync('test/_tmp/input/[foo]/bar.js', `export const bar = 43;`);
+						},
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.equal(run('../_tmp/output/bundle.js'), 43);
+						}
+					]);
+				});
+		});
 	}
 });

test/watch/samples/non-glob/[foo]/bar.js

@@ -0,0 +1 @@
+export const bar = 42;

test/watch/samples/non-glob/main.js

@@ -0,0 +1,3 @@
+import { bar } from './[foo]/bar.js';
+
+export default bar;