Detect side-effects in method arguments of unknown strings (#2476)

src/ast/values.ts

@@ -254,10 +254,9 @@ const UNKNOWN_LITERAL_STRING: ExpressionEntity = {
 	},
 	hasEffectsWhenAccessedAtPath: path => path.length > 1,
 	hasEffectsWhenAssignedAtPath: path => path.length > 0,
-	hasEffectsWhenCalledAtPath: path => {
+	hasEffectsWhenCalledAtPath: (path, callOptions, options) => {
 		if (path.length === 1) {
-			const subPath = path[0];
-			return typeof subPath !== 'string' || !literalStringMembers[subPath];
+			return hasMemberEffectWhenCalled(literalStringMembers, path[0], true, callOptions, options);
 		}
 		return true;
 	},

test/function/samples/builtin-prototypes/argument-side-effects/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'detects side-effects in chained string method arguments'
+};

test/function/samples/builtin-prototypes/argument-side-effects/main.js

@@ -0,0 +1,11 @@
+function getData() {
+	var data = [];
+
+	'abc'.trim().replace('b', function() {
+		data.push('replaced');
+	});
+
+	return data;
+}
+
+assert.deepEqual(getData(), ['replaced']);