Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Commit

Permalink
FIX: Stop mutating values option (#22)
Browse files Browse the repository at this point in the history
* FIX: Stop mutating values option

* Add regression unit test

* lint

* Safety first
  • Loading branch information
caccialdo authored and lukastaegert committed Oct 6, 2018
1 parent a0a7473 commit 0b62100
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
11 changes: 6 additions & 5 deletions src/index.js
Expand Up @@ -21,7 +21,7 @@ export default function replace(options = {}) {
let values;

if (options.values) {
values = options.values;
values = Object.assign({}, options.values);
} else {
values = Object.assign({}, options);
delete values.delimiters;
Expand All @@ -42,9 +42,10 @@ export default function replace(options = {}) {
);

// convert all values to functions
Object.keys(values).forEach(key => {
values[key] = functor(values[key]);
});
const functionValues = Object.keys(values).reduce((acc, key) => {
acc[key] = functor(values[key]);
return acc;
}, {});

return {
name: 'replace',
Expand All @@ -63,7 +64,7 @@ export default function replace(options = {}) {

start = match.index;
end = start + match[0].length;
replacement = String(values[match[1]](id));
replacement = String(functionValues[match[1]](id));

magicString.overwrite(start, end, replacement);
}
Expand Down
13 changes: 13 additions & 0 deletions test/test.js
Expand Up @@ -36,6 +36,19 @@ describe('rollup-plugin-replace', () => {
assert.equal(code.trim(), 'console.log(42);');
});

it('does not mutate the values map properties', async () => {
const valuesMap = { ANSWER: '42' }
const bundle = await rollup({
input: 'samples/basic/main.js',
plugins: [
replace({ values: valuesMap })
]
});

await bundle.generate({ format: 'es' });
assert.equal(valuesMap.ANSWER, '42');
});

it('allows replacement to be a function', async () => {
const bundle = await rollup({
input: 'samples/relative/main.js',
Expand Down

0 comments on commit 0b62100

Please sign in to comment.