add test for export 'default' warning

rollup · Oct 13, 2017 · 14bdcf2 · 14bdcf2
1 parent c6a0d0e
commit 14bdcf2
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/test/samples/es-modules-without-default-export/main.js b/test/samples/es-modules-without-default-export/main.js
@@ -0,0 +1,3 @@
+const { a } = require('./other.js');
+
+assert.equal( a, 1 );
diff --git a/test/samples/es-modules-without-default-export/other.js b/test/samples/es-modules-without-default-export/other.js
@@ -0,0 +1 @@
+export const a = 1;
diff --git a/test/test.js b/test/test.js
@@ -94,7 +94,7 @@ describe( 'rollup-plugin-commonjs', () => {
 			( config.solo ? it.only : it )( dir, async () => {
 				const options = Object.assign({
 					input: `function/${dir}/main.js`,
-					plugins: [ commonjs( config.pluginOptions ) ]
+					plugins: [ commonjs( config.pluginOptions ) ],
 				}, config.options || {} );
 
 				const bundle = await rollup( options );
@@ -432,5 +432,22 @@ describe( 'rollup-plugin-commonjs', () => {
 			await executeBundle( bundle, { context: { window } } );
 			assert.notEqual( window.b.default, undefined );
 		});
+
+		it( 'does not warn even if the ES module not export "default"', async () => {
+			const warns = [];
+			await rollup({
+				input: 'samples/es-modules-without-default-export/main.js',
+				plugins: [ commonjs() ],
+				onwarn: (warn) => warns.push( warn )
+			});
+			assert.equal( warns.length, 0 );
+
+			await rollup({
+				input: 'function/bare-import/bar.js',
+				plugins: [ commonjs() ],
+				onwarn: (warn) => warns.push( warn )
+			});
+			assert.equal( warns.length, 0 );
+		});
 	});
-});
+});