Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restart on change for non-default signals (#1409) #1430

Merged
merged 1 commit into from Nov 5, 2018
Merged

fix: restart on change for non-default signals (#1409) #1430

merged 1 commit into from Nov 5, 2018

Commits on Nov 2, 2018

  1. fix: restart on change for non-default signals (remy#1409) 

    When nodemon kills the child app in preparation for a restart, the app may exit
with a non-zero status code, especially when using custom signals like SIGINT.
Previously, this would be detected as a clean exit rather than a restart, at
least on macOS.

There was an existing flag, `killedAfterChange` which causes the desired
behavior, but it was only set on Windows. It seems that setting it always leaked
between tests and caused problems, so we only set it if a restart is expected.

Fixes remy#1409
    @aaronjensen
    aaronjensen committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    0b9e9fd View commit details
    Browse the repository at this point in the history