Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move both auto-changelog recipes to the /conf directory #587

Merged
merged 1 commit into from Jan 16, 2020
Merged

Move both auto-changelog recipes to the /conf directory #587

merged 1 commit into from Jan 16, 2020

Conversation

ruzickap
Copy link
Contributor

Move both changelog-compact-template.hbs and keepachangelog.hbs
auto-changelog recipes to the /conf directory, because they are more
like config files of auto-changelog than part of the documentation.
Change the documentation file related to auto-changelog to show examples
using recipes from this repository (--template https://...).

@webpro
Copy link
Collaborator

webpro commented Jan 15, 2020

Thanks @ruzickap! I really appreciate this. One minor thing: could you please remove the -template suffix from the filename(s), as I think "hbs" already implicates they're templates files, right?

Move both `changelog-compact-template.hbs` and `keepachangelog.hbs`
auto-changelog recipes to the `/conf` directory, because they are more
like config files of auto-changelog than part of the documentation.
Change the documentation file related to auto-changelog to show examples
using recipes from this repository (`--template https://...`).
@ruzickap
Copy link
Contributor Author

Good point.
Changed...

@webpro webpro merged commit b90831a into release-it:master Jan 16, 2020
@webpro
Copy link
Collaborator

webpro commented Jan 16, 2020

Thanks again!

@ruzickap ruzickap deleted the auto-changelog branch January 16, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants