Fix tag prefix #84
Open
Fix tag prefix #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webpro Here's my PR as you suggested, let me know if it makes sense to you. |
webpro
reviewed
Apr 5, 2024
index.js
Outdated
| @@ -35,8 +36,14 @@ class ConventionalChangelog extends Plugin { | |||
| const { options } = this; | |||
| this.debug({ increment, latestVersion, isPreRelease, preReleaseId }); | |||
| this.debug('conventionalRecommendedBump', { options }); | |||
| let { tagPrefix } = options | |||
| const npmName = this.config?.contextOptions?.npm?.name | |||
There was a problem hiding this comment.
Please use this.config.getContext('npm.name')
jordanrastrick
force-pushed
the
fix-tag-prefix
branch
from
a078fb1
to
bc8bb2d
Compare
|
Sorry @webpro, I'm only using this package in private repositories that can't be shared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issues raised here.
Two fixes to the functioning of
tagPrefix:tagPrefixoption is explicitly given in settings, don't override it with the derived prefix fromtagName.${npm.name}variable is present intagPrefix, interpolate it's value before passing through toconventional-recommended-bumpCaveats:
Does not address interpolating any other variable except
npm.name(which presumably would be much less common intagPrefix) - I'm not familiar enough with therelease-itarchitecture to see how to do this well.These are conservative changes in that they shouldn't affect people not trying to use these options/variables.