Skip to content

Commit

Permalink
Housekeeping
Browse files Browse the repository at this point in the history
  • Loading branch information
webpro committed Apr 8, 2020
1 parent ece7f23 commit 5f0d4dd
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 14 deletions.
4 changes: 3 additions & 1 deletion .prettierrc
@@ -1,5 +1,7 @@
{
"printWidth": 120,
"singleQuote": true,
"proseWrap": "always"
"proseWrap": "always",
"arrowParens": "avoid",
"trailingComma": "none"
}
6 changes: 3 additions & 3 deletions index.js
Expand Up @@ -19,11 +19,11 @@ class ConventionalChangelog extends Plugin {
this.debug({ err, result });
if (err) return reject(err);
let { releaseType } = result;
if(increment) {
this.log.warn(`Recommended bump is "${releaseType}", but is overridden with "${increment}".`)
if (increment) {
this.log.warn(`Recommended bump is "${releaseType}", but is overridden with "${increment}".`);
releaseType = increment;
}
if(increment && semver.valid(increment)) {
if (increment && semver.valid(increment)) {
resolve(increment);
} else if (releaseType) {
const type = isPreRelease ? `pre${releaseType}` : releaseType;
Expand Down
8 changes: 4 additions & 4 deletions package.json
Expand Up @@ -32,14 +32,14 @@
"dependencies": {
"concat-stream": "^2.0.0",
"conventional-changelog": "^3.1.8",
"conventional-recommended-bump": "^5.0.0",
"conventional-recommended-bump": "^6.0.5",
"prepend-file": "^1.3.1",
"release-it": "^12.3.0"
"release-it": "^13.5.2"
},
"devDependencies": {
"bron": "0.0.1",
"bron": "^1.1.1",
"proxyquire": "^2.1.0",
"sinon": "^7.3.1"
"sinon": "^9.0.1"
},
"engines": {
"node": ">=8"
Expand Down
12 changes: 6 additions & 6 deletions test.js
Expand Up @@ -13,14 +13,14 @@ const conventionalRecommendedBump = sinon.stub().callsFake((options, cb) => {
});

const conventionalChangelog = sinon.stub().callsFake(options => {
const s = new stream.Readable();
s._read = () => {};
const readableStream = new stream.Readable();
readableStream._read = () => {};
process.nextTick(() => {
s.emit('data', 'The changelog');
if (options.releaseCount < 0) s.emit('error', new Error('Something went wrong'));
s.emit('end');
readableStream.emit('data', 'The changelog');
if (options.releaseCount < 0) readableStream.emit('error', new Error('Something went wrong'));
readableStream.emit('end');
});
return s;
return readableStream;
});

const Plugin = proxyquire('.', {
Expand Down

0 comments on commit 5f0d4dd

Please sign in to comment.