Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React.createContext() by @cellog #1000

Merged
merged 26 commits into from Nov 6, 2018
Merged

Commits on Oct 28, 2018

  1. alternate 6.x implementation

    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    a487814 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b93bc80 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    d97cf23 View commit details
    Browse the repository at this point in the history
  4. fix renderCountProp, add a test

    also clean up unused canary values
    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    198eba1 View commit details
    Browse the repository at this point in the history
  5. remove errant console.log

    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    cc657a1 View commit details
    Browse the repository at this point in the history
  6. expose context consumer and provider

    This will allow third party apps to use these in their code
    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    a945169 View commit details
    Browse the repository at this point in the history
  7. changes requested by @timdorr

    * export Context instead of just Consumer/Provider
    * fix error messages for removed functionality
    * minor displayName change
    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    2dd0bf9 View commit details
    Browse the repository at this point in the history
  8. keep prop-types in production minified UMD build

    when the time is right, one need only
    change the BABEL_ENV for build:umd:min back to "rollup-production"
    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    d3e8d99 View commit details
    Browse the repository at this point in the history
  9. performance optimizations: HEADS UP API change too

    * React.forwardRef is VERY slow, on the order of 2x slower in our benchmark. So we only enable it if withRef="forwardRef" folks using withRef=true will get an error telling them to update and not rely on getWrappedInstance() but just to use the ref directly
    * renderCountProp is removed, as this is natively supported in React dev tools now
    * all usages of shallowEquals are removed for pure components, it was unnecessary.
    * instead of allowing passing in a custom Context consumer in props, it is now required to be passed in via connect options at declaration time.
    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    664b0c6 View commit details
    Browse the repository at this point in the history
  10. small optimizations/refactors

    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    5a7aa27 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    f3f5fca View commit details
    Browse the repository at this point in the history
  12. update hoist-non-react-statics

    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    f3b42b8 View commit details
    Browse the repository at this point in the history
  13. cosmetics

    cellog authored and timdorr committed Oct 28, 2018
    Copy the full SHA
    ca9b551 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    24af213 View commit details
    Browse the repository at this point in the history
  15. Less package-lock.json noise

    timdorr committed Oct 28, 2018
    Copy the full SHA
    e742cae View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. Copy the full SHA
    9434422 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Copy the full SHA
    6bed812 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    93fb69b View commit details
    Browse the repository at this point in the history
  3. Rework Provider tests

    markerikson committed Nov 1, 2018
    Copy the full SHA
    106a7e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Rework connect tests, combine warnings, and remove observedBits

    Ported connect test handling from 995
    Deduped the "custom store context" messages
    Removed use of observedBits for now
    Commented out derivedProps propTypes that caused test failures
    markerikson committed Nov 6, 2018
    Copy the full SHA
    259253a View commit details
    Browse the repository at this point in the history
  2. Rework connect component based on review notes

    Removed use of PureWrapper
    Used React.memo() on the wrapped component
    Renamed and extracted makeDerivedPropsSelector
    Added makeChildElementSelector
    Simplified render props callback
    Simplified forwardRef handling
    markerikson committed Nov 6, 2018
    Copy the full SHA
    c9d5973 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    58dcf33 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    2d06cdf View commit details
    Browse the repository at this point in the history
  5. Fix lint warnings

    markerikson committed Nov 6, 2018
    Copy the full SHA
    5306b38 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    2418592 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    4953214 View commit details
    Browse the repository at this point in the history