Don't call setState in Provider if unmounting

reduxjs · Aug 14, 2018 · a64103c · a64103c
1 parent 0374936
commit a64103c
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/components/Provider.js b/src/components/Provider.js
@@ -40,12 +40,25 @@ export function createProvider(storeKey = 'store') {
             this.subscribe();
         }
 
+        componentWillUnmount() {
+          if(this.unsubscribe) {
+            this.unsubscribe()
+            this._isMounted = false;
+          }
+        }
+
         subscribe() {
           const {store} = this.props;
 
+          this._isMounted = true;
+
           this.unsubscribe = store.subscribe( () => {
             const newStoreState = store.getState();
 
+            if(!this._isMounted) {
+              return;
+            }
+
             this.setState(providerState => {
               // If the value is the same, skip the unnecessary state update.
               if(providerState.storeState === newStoreState) {