Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for all hash field expiration commands #2742

Open
wants to merge 4 commits into
base: v5
Choose a base branch
from
Open

add support for all hash field expiration commands #2742

wants to merge 4 commits into from

Conversation

sjpotter
Copy link
Contributor

Description

adds the has field expiration commands - for testing purposes, need a docker container that has it in it.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@sjpotter sjpotter requested a review from leibale April 17, 2024 12:41
leibale
leibale reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, but:

  1. I've made some changes, please review them..
  2. Seems like HGETF and HSETF are missing

@sjpotter
Copy link
Contributor Author

sjpotter commented May 9, 2024

change look fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leibale leibale leibale left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjpotter @leibale