New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bootstrap Icons & Sort Sidebar Items #275
Conversation
thank you for your contribution. it's great work! If the conflict is cleared, merge. |
Much appreciated! I don’t have write access to the repo, so I can’t merge. I believe the CI check failed due to not having the deploy api key in my environment variables. |
Hi @kamijin-fanta - added a few more commits here as you can see. I noticed that you merged the RemixIcon PR (great icon set, glad to see it added!), and are moving the codebase to TypeScript, so my original commits needed some shifting around to fit in. I believe I've made all the necessary changes, as well as some extras on the Preview site. Looks like you've started moving to NextJS, so I moved my original CRA changes (sorting the sidebar) over to the Next config, and fixed an issue I found when trying to run the dev server locally ( Thanks, |
Thank you. Great contribution! CI will be modified in another PR. |
Hello!
Thank you for creating and maintaining this project, I find it extremely valuable. This PR should be mergeable as-is, but if not, I'd love to know of any other things that need to be done when adding an icon library. I have:
packages/react-icons/src/icons/index.js
and included the required glob filters for thereverse
andfill
variants/bs/
package/preview/node_modules
and verified that all the new icons appear properlyThanks again!
PS: If the process I just followed is correct (or if not, and you let me know what's missing), I'd be happy to write up a brief contributing doc for future contributors. Just let me know!