Skip to content

Commit

Permalink
Clarify naming expectation for glyph prop
Browse files Browse the repository at this point in the history
It was not immediately obvious to remove the prefix since we specify using the icon name with a link to bootstrap which does use the prefix. It was only after looking at the sample and my written code that I noticed the difference.
  • Loading branch information
sidewaysgravity committed Feb 10, 2017
1 parent 0094c5a commit fa1097e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Glyphicon.js
Expand Up @@ -6,7 +6,7 @@ import { bsClass, getClassSet, prefix, splitBsProps }

const propTypes = {
/**
* An icon name. See e.g. http://getbootstrap.com/components/#glyphicons
* An icon name without "glyphicon-" prefix. See e.g. http://getbootstrap.com/components/#glyphicons
*/
glyph: React.PropTypes.string.isRequired,
};
Expand Down

0 comments on commit fa1097e

Please sign in to comment.