Skip to content

Commit

Permalink
switch the package managers name printed out when yarn.lock file is p…
Browse files Browse the repository at this point in the history
…resent
  • Loading branch information
Sam De Maeyer committed Mar 20, 2017
1 parent ccd0125 commit 7a6ca3b
Show file tree
Hide file tree
Showing 6 changed files with 123 additions and 2 deletions.
11 changes: 9 additions & 2 deletions lib/dependency-checker.js
Expand Up @@ -46,8 +46,15 @@ EmberCLIDependencyChecker.prototype.checkDependencies = function() {
var unsatisfiedDeps = filteredDeps.filter(isNotSymlinked);
var symlinkedDeps = filteredDeps.filter(isSymlinked);

this.reporter.reportUnsatisfiedSymlinkedPackages('npm', symlinkedDeps);
this.reporter.unsatisifedPackages('npm', unsatisfiedDeps);
var yarnPath = path.join(this.project.root, 'yarn.lock');

var packageManagerName = 'npm';
if (fileExists(yarnPath)) {
packageManagerName = 'yarn';
}

this.reporter.reportUnsatisfiedSymlinkedPackages(packageManagerName, symlinkedDeps);
this.reporter.unsatisifedPackages(packageManagerName, unsatisfiedDeps);

if (unsatisfiedDeps.length === 0) {
var shrinkWrapDeps = this.readShrinkwrapDeps();
Expand Down
2 changes: 2 additions & 0 deletions lib/reporter.js
Expand Up @@ -4,6 +4,8 @@ function installCommand(type) {
switch (type) {
case 'npm':
return 'npm install';
case 'yarn':
return 'yarn';
case 'npm-shrinkwrap':
return 'rm -rf node_modules/ && npm install';
case 'bower':
Expand Down
5 changes: 5 additions & 0 deletions tests/fixtures/project-yarn-check/bower.json
@@ -0,0 +1,5 @@
{
"name": "project-npm-check",
"dependencies": {
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
103 changes: 103 additions & 0 deletions tests/unit/dependency-checker-yarn-test.js
@@ -0,0 +1,103 @@
'use strict';

var assertError = require('../helpers/assert-error');
var assertNoError = require('../helpers/assert-no-error');
var DependencyChecker = require('../../lib/dependency-checker');
var projectBuilder = require('../helpers/project-builder');

describe('EmberCLIDependencyChecker', function() {
beforeEach(function(){
DependencyChecker.setAlreadyChecked(false);
});

function createProject(dependencies, options) {
options = options || {};
options.root = options.root || 'tests/fixtures/project-yarn-check';
options.dependencies = projectBuilder.buildDependencies(dependencies);
return projectBuilder.build(options);
}

var assertNpmError = function(project) {
return assertError(project, 'yarn');
};

var assertNoNpmError = function(project) {
return assertNoError(project, 'yarn');
};

describe('reports unsatisfied NPM dependencies', function() {
it('when the specified package is not installed', function() {
var project = createProject({ 'foo': '0.1.1', 'ember-cli': '1.2.3' });
assertNpmError(project);
});

it('when the installed package does not match the version specified', function() {
var project = createProject({ 'ember-cli': '0.1.1' });
assertNpmError(project);
});

it('when the installed package does not satisfy the version range specified', function() {
var project = createProject({ 'ember-cli': '>1.3.2 <=2.3.4' });
assertNpmError(project);
});

it('when the installed package is not compatible with the version specified', function() {
var project = createProject({ 'ember-cli': '0.2.x' });
assertNpmError(project);
});

it('when the version specified is a Git repo with a semver tag and there is a version mismatch', function() {
var project = createProject({ 'ember-cli': 'git://github.com/stefanpenner/ember-cli.git#v0.1.0' });
assertNpmError(project);
});
});

describe('does not report satisfied NPM dependencies', function() {
it('when the installed package matches the version specified', function() {
var project = createProject({ 'ember-cli': '1.2.3' });
assertNoNpmError(project);
});

it('when the installed package satisfies the version range specified', function() {
var project = createProject({ 'ember-cli': '>1.0.0' });
assertNoNpmError(project);
});

it('when the installed package is compatible with the version specified', function() {
var project = createProject({ 'ember-cli': '^1.2.0' });
assertNoNpmError(project);
});

it('when the version specified is a URL', function() {
var project = createProject({ 'ember-cli': 'http://ember-cli.com/ember-cli.tar.gz' });
assertNoNpmError(project);
});

it('when the version specified is a Git repo with a non-semver tag', function() {
var project = createProject({ 'ember-cli': 'git://github.com/stefanpenner/ember-cli.git#master' });
assertNoNpmError(project);
});

it('when the version specified is a local path', function() {
var project = createProject({ 'ember-cli': '~/projects/ember-cli' });
assertNoNpmError(project);
});

it('does NOT error with a * dependency', function() {
var project = createProject({ 'ember-cli': '*' });
assertNoNpmError(project);
});
});

describe('sibling node_modules/ directory', function() {
it('checks depdencies', function() {
var project = createProject({
'ember-cli': '*'
}, {
root: 'tests/fixtures/project-npm-sibling-node-modules-check/app',
nodeModulesPath: 'tests/fixtures/project-npm-sibling-node-modules-check/node_modules',
});
assertNoNpmError(project);
});
});
});

0 comments on commit 7a6ca3b

Please sign in to comment.