Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(network): align HTTP status codes with IANA #4567

Merged
merged 2 commits into from
Jun 11, 2019
Merged

fix(network): align HTTP status codes with IANA #4567

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba389e
fix(network): align HTTP status codes with IANA
aslushnikov Jun 11, 2019
f539b4f
drop unassigned
aslushnikov Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/NetworkManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,19 +728,22 @@ function headersArray(headers) {
return result;
}

// List taken from https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml with extra 306 and 418 codes.
const STATUS_TEXTS = {
'100': 'Continue',
'101': 'Switching Protocols',
'102': 'Processing',
'103': 'Early Hints',
'200': 'OK',
'201': 'Created',
'202': 'Accepted',
'203': 'Non-Authoritative Information',
'204': 'No Content',
'205': 'Reset Content',
'206': 'Partial Content',
'207': 'Multi-Status',
'208': 'Already Reported',
'209': 'IM Used',
'226': 'IM Used',
'300': 'Multiple Choices',
'301': 'Moved Permanently',
'302': 'Found',
Expand Down Expand Up @@ -773,9 +776,12 @@ const STATUS_TEXTS = {
'422': 'Unprocessable Entity',
'423': 'Locked',
'424': 'Failed Dependency',
'425': 'Too Early',
'426': 'Upgrade Required',
'427': 'Unassigned',
'428': 'Precondition Required',
'429': 'Too Many Requests',
'430': 'Unassigned',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unassigned just means unassigned, its not a specific code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed!

'431': 'Request Header Fields Too Large',
'451': 'Unavailable For Legal Reasons',
'500': 'Internal Server Error',
Expand Down