Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cookies): cookies from headful now work in headless #3481

Merged
merged 1 commit into from
Nov 2, 2018
Merged

test(cookies): cookies from headful now work in headless #3481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/headful.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,13 @@

const path = require('path');
const os = require('os');
const fs = require('fs');
const rm = require('rimraf').sync;
const {helper} = require('../lib/helper');
const utils = require('./utils');
const {waitEvent} = utils;
const puppeteer = utils.requireRoot('index.js');
const mkdtempAsync = helper.promisify(fs.mkdtemp);

const TMP_FOLDER = path.join(os.tmpdir(), 'pptr_tmp_folder-');

Expand Down Expand Up @@ -79,7 +83,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions})
expect(pages).toEqual(['about:blank']);
await browser.close();
});
xit('headless should be able to read cookies written by headful', async({server}) => {
it('headless should be able to read cookies written by headful', async({server}) => {
const userDataDir = await mkdtempAsync(TMP_FOLDER);
// Write a cookie in headful chrome
const headfulBrowser = await puppeteer.launch(Object.assign({userDataDir}, headfulOptions));
Expand Down