Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(puppeteer): support convenience env variables #3190

Merged
merged 3 commits into from
Sep 5, 2018
Merged

feat(puppeteer): support convenience env variables #3190

merged 3 commits into from
Sep 5, 2018

Commits on Sep 5, 2018

  1. feat(puppeteer): support convenience env variables 

    We had (and still have) a ton of pull requests to support
PUPPETEER_EXECUTABLE_PATH and PUPPETEER_CHROMIUM_REVISION in puppeteer launcher.

We were hesitant before since env variables are not scoped
and thus don't make a good interface for a library. Now, since we
determined `puppeteer-core` as a library and `puppeteer` as our end-user
product, it's safe to satisfy our user needs.

This patch:
- teaches PUPPETEER_EXECUTABLE_PATH and PUPPETEER_CHROMIUM_REVISION
  env variables to control how Puppeteer launches browser
- makes sure these variables play no role in `puppeteer-core` package.
    @aslushnikov
    aslushnikov committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    bcb58dd View commit details
    Browse the repository at this point in the history

  2. address comments

    @aslushnikov
    aslushnikov committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    df266e9 View commit details
    Browse the repository at this point in the history

  3. comma

    @aslushnikov
    aslushnikov committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    a74968b View commit details
    Browse the repository at this point in the history