Add a failing test for storing cookies #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Oct 17, 2017
|
FWIW, the issue is not only storing but also reading (and sending), In this examples, cookies are stored with |
|
@vsemozhetbyt the headless and headful modes maintain a different directory structure; we'll probably need to highlight this somewhere in the docs/api. |
|
Well, this can be a problem. How can users log in to sites to use them headlessly? Should they replace this directory structure manually? |
Yes, this is very uncomfortable. Filed upstream crbug.com/775703 |
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
|
that crbug was closed as fixed yet it doesn't seem like it's maintaining the same structure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.