Allow creating robot without a logger

probot · Jun 30, 2017 · aa3146b · aa3146b
1 parent 0078c31
commit aa3146b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/lib/robot.js b/lib/robot.js
@@ -137,11 +137,11 @@ function rateLimitedClient(github) {
 //     robot.log.trace("verbose details");
 //
 function wrapLogger(logger) {
-  const fn = logger.debug.bind(logger);
+  const fn = logger ? logger.debug.bind(logger) : function () { };
 
   // Add level methods on the logger
   ['trace', 'debug', 'info', 'warn', 'error', 'fatal'].forEach(level => {
-    fn[level] = logger[level].bind(logger);
+    fn[level] = logger ? logger[level].bind(logger) : function () { };
   });
 
   return fn;

diff --git a/test/robot.js b/test/robot.js
@@ -2,23 +2,12 @@ const expect = require('expect');
 const Context = require('../lib/context');
 const createRobot = require('../lib/robot');
 
-function createNullLogger() {
-  const logger = expect.createSpy();
-
-  ['trace', 'debug', 'info', 'warn', 'error', 'fatal'].forEach(level => {
-    logger[level] = expect.createSpy();
-  });
-
-  return logger;
-}
-
 describe('Robot', function () {
   let webhook;
   let robot;
   let event;
   let callbacks;
   let spy;
-  let logger;
 
   beforeEach(function () {
     callbacks = {};
@@ -33,8 +22,7 @@ describe('Robot', function () {
       }
     };
 
-    logger = createNullLogger();
-    robot = createRobot({webhook, logger});
+    robot = createRobot({webhook});
     robot.auth = () => {};
 
     event = {
@@ -76,14 +64,15 @@ describe('Robot', function () {
   describe('error handling', () => {
     it('logs errors throw from handlers', async () => {
       const error = new Error('testing');
+      robot.log.error = expect.createSpy();
 
       robot.on('test', () => {
         throw error;
       });
 
       await webhook.emit('test', event);
 
-      expect(logger.error).toHaveBeenCalledWith(error);
+      expect(robot.log.error).toHaveBeenCalledWith(error);
     });
   });
 });