Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor Link in Docs #768

Merged
merged 15 commits into from Apr 30, 2019
Merged

Anchor Link in Docs #768

merged 15 commits into from Apr 30, 2019

Conversation

emplums
Copy link
Contributor

@emplums emplums commented Apr 25, 2019 •
edited

This PR adds anchor links in the documentation :)

  • I branched off of Update Blueprints #764, the relevant changes are in markdown.js and _app.js
    cc @primer/design-systems

@emplums emplums requested a review from shawnbot April 25, 2019 19:51
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
docs/markdown.js Outdated Show resolved Hide resolved
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
pages/_app.js Outdated Show resolved Hide resolved
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
pages/_error.js Outdated Show resolved Hide resolved
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
pages/index.js Outdated Show resolved Hide resolved
@shawnbot shawnbot added this to Ready to release in 📦 Primer CSS release tracking Apr 29, 2019
@shawnbot shawnbot mentioned this pull request Apr 29, 2019
Merged
13 tasks
shawnbot and others added 8 commits April 30, 2019 11:05
@shawnbot
Update docs/markdown.js
e5bbf73 
Co-Authored-By: emplums <emplums@github.com>
@shawnbot
Update pages/_app.js
9c7119a 
Co-Authored-By: emplums <emplums@github.com>
@shawnbot
Update pages/index.js
9dca6cc 
Co-Authored-By: emplums <emplums@github.com>
@shawnbot
Update pages/_error.js
d00d2c3 
Co-Authored-By: emplums <emplums@github.com>
update blueprints version
861c9fd
Merge branch 'update-blueprints' of github.com:primer/css into update…
5941b76 
…-blueprints
Merge pull request #764 from primer/update-blueprints
9ed1375 
Update Blueprints
Merge branch 'master' into anchor-links
14b4a60
@shawnbot shawnbot changed the base branch from master to release-12.3.0 April 30, 2019 18:20
shawnbot
shawnbot approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray, thanks!

@shawnbot shawnbot merged commit 34d787e into release-12.3.0 Apr 30, 2019
📦 Primer CSS release tracking automation moved this from Ready to release to 💜 Done Apr 30, 2019
@shawnbot shawnbot deleted the anchor-links branch April 30, 2019 18:21
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
Tag: Documentation
Projects
No open projects
📦 Primer CSS release tracking
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emplums @shawnbot