Support toplevel interpolations in graphql tags #3370
Conversation
|
|
||
| # comment | ||
| \${test} # comment | ||
| \` |
There was a problem hiding this comment.
All the comments after the interpolations here are currently moved to the next line. Is this a deal-breaker? This seems to require some larger changes to made.
There was a problem hiding this comment.
Probably not a deal-breaker. I'm guessing comments are pretty uncommon here. I've only ever used comments in GraphQL schemas.
|
Multiparser refactor looks good. Haven't reviewed GraphQL changes properly yet but test outputs look good. |
|
I need to figure out why the |
src/multiparser.js
Outdated
| } | ||
| } | ||
|
|
||
| function fromMarkdown(path, options) { | ||
| function parseAndPrint(passedOptions) { |
There was a problem hiding this comment.
You'd need to pass the previous and next options here so the parentParser thing works.. see printSubtree how it builds next.options but gets the parentParser from options
Right now, you have parser === parentParser
lydell
changed the title
|
I think I'm happy with this now. Would be awesome if it could make it into the 1.9 release! |
@azz Do you want to take a look before merging, or should I just press the green button? |
lock
bot
added
the
locked-due-to-inactivity
Fixes #3318.