Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve intentional new lines in GraphQL #3252

Merged
merged 5 commits into from Nov 12, 2017
Merged

Preserve intentional new lines in GraphQL #3252

merged 5 commits into from Nov 12, 2017

Conversation

duailibe
Copy link
Member

Fix #3251

azz
azz approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@azz azz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you add a test with comments on the fields as that's the primary use case.

@duailibe
Copy link
Member Author

Will do!

I should also add support to newlines inside arguments, as the example in the issue also contains them

azz
azz reviewed Nov 12, 2017
View reviewed changes
tests/graphql_newline/__snapshots__/jsfmt.spec.js.snap

# comment
arg2: 10
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks odd to me

Copy link
Member Author

@duailibe duailibe Nov 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the current behavior when it breaks: playground link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Don't have any better ideas either. Fine to leave it.

@duailibe duailibe merged commit ece764a into prettier:master Nov 12, 2017
@duailibe duailibe deleted the gql-fields-newline branch November 12, 2017 04:11
@exogen exogen mentioned this pull request Nov 18, 2017
Merged
@suchipi suchipi added this to the 1.9 milestone Nov 28, 2017
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azz azz azz approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duailibe @azz @suchipi