Don't break self closing elements with no attributes #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duailibe
commented
Nov 11, 2017
| // ---------- | ||
| x = ( | ||
| <p> | ||
| text text text text text text text text text text text text text text text<br />text |
There was a problem hiding this comment.
To help review, the print width is in the middle of <br />
lydell
reviewed
Nov 11, 2017
src/printer.js
Outdated
| n.name && n.name.comments && n.name.comments.length; | ||
|
|
||
| // Don't break self-closing elements with no attributes and no comments | ||
| if (n.selfClosing && (!n.attributes || !n.attributes.length) && !nameHasComments) { |
There was a problem hiding this comment.
As far as I can tell from the next if-statement, n.attributes is always an array, so there’s no need to check if it exists.
There was a problem hiding this comment.
Yeah I was just following some previous code. I never know when properties that can be empty arrays can be undefined.
suchipi
approved these changes
Nov 13, 2017
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3234