Add support for JSX fragments #3237
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`fragment.js 1`] = ` | ||
| <></>; | ||
|
There was a problem hiding this comment. Might be worth adding a "complex" nested fragment example (here's the one from Babylon): <div>
<>
<>
<span>Hello</span>
<span>world</span>
</>
<>
<span>Goodbye</span>
<span>world</span>
</>
</>
</div>EDIT: nvm, noticed your comment re: tests in the PR desc |
||
|
|
||
| <> | ||
| text | ||
| </>; | ||
|
|
||
| <> | ||
| <Component /> | ||
| <Component /> | ||
| </>; | ||
|
|
||
| <> | ||
| text | ||
| <h2>heading</h2> | ||
| text | ||
| <h2>heading</h2> | ||
| text | ||
| </>; | ||
|
|
||
| <div> | ||
| <> | ||
| <> | ||
| <span>Hello</span> | ||
| <span>world</span> | ||
| </> | ||
| <> | ||
| <span>Goodbye</span> | ||
| <span>world</span> | ||
| </> | ||
| </> | ||
| </div>; | ||
|
|
||
| </* open fragment */> | ||
| <Component /> | ||
| <Component /> | ||
| </ /* close fragment */>; | ||
|
|
||
| < // open fragment | ||
| > | ||
| <Component /> | ||
| <Component /> | ||
| </ // close fragment | ||
| >; | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| <></>; | ||
|
|
||
| <>text</>; | ||
|
|
||
| <> | ||
| <Component /> | ||
| <Component /> | ||
| </>; | ||
|
|
||
| <> | ||
| text | ||
| <h2>heading</h2> | ||
| text | ||
| <h2>heading</h2> | ||
| text | ||
| </>; | ||
|
|
||
| <div> | ||
| <> | ||
| <> | ||
| <span>Hello</span> | ||
| <span>world</span> | ||
| </> | ||
| <> | ||
| <span>Goodbye</span> | ||
| <span>world</span> | ||
| </> | ||
| </> | ||
| </div>; | ||
|
|
||
| </* open fragment */> | ||
| <Component /> | ||
| <Component /> | ||
| <//* close fragment */>; | ||
|
|
||
| < | ||
| // open fragment | ||
| > | ||
| <Component /> | ||
| <Component /> | ||
| </ | ||
| // close fragment | ||
|
There was a problem hiding this comment. For a self-closing JSX tag, we would put the "closing slash" after the comment or attributes. Maybe we should do the same thing for fragments? Prettier 1.8.2 Input: <div
/* foo */
/>;
<div
a={a}
b={reallyreallyreallyreallyreallyreallyreallyreallyreallyreallylong}
/>;Output: <div
/* foo */
/>;
<div
a={a}
b={reallyreallyreallyreallyreallyreallyreallyreallyreallyreallylong}
/>;There was a problem hiding this comment. I was thinking more of this case: Input: <div>
Text
</div /* comment */>;
<div>
Text
</* comment */ /div>;Output: <div>Text</div /* comment */>;
<div>Text<//* comment */ div>;There was a problem hiding this comment. Since you can't put attributes in a jsx fragment (afaik), I guess it only affects comments, so it's probably fine either way |
||
| >; | ||
|
|
||
| `; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <></>; | ||
|
|
||
| <> | ||
| text | ||
| </>; | ||
|
|
||
| <> | ||
| <Component /> | ||
| <Component /> | ||
| </>; | ||
|
|
||
| <> | ||
| text | ||
| <h2>heading</h2> | ||
| text | ||
| <h2>heading</h2> | ||
| text | ||
| </>; | ||
|
|
||
| <div> | ||
| <> | ||
| <> | ||
| <span>Hello</span> | ||
| <span>world</span> | ||
| </> | ||
| <> | ||
| <span>Goodbye</span> | ||
| <span>world</span> | ||
| </> | ||
| </> | ||
| </div>; | ||
|
|
||
| </* open fragment */> | ||
| <Component /> | ||
| <Component /> | ||
| </ /* close fragment */>; | ||
|
|
||
| < // open fragment | ||
| > | ||
| <Component /> | ||
| <Component /> | ||
| </ // close fragment | ||
| >; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| run_spec(__dirname); | ||
|
There was a problem hiding this comment. Can we turn on |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh... thanks for catching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I fixed before merging... lucky :-)