Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip BOM before parsing #2373

Merged
merged 1 commit into from Jul 1, 2017
Merged

Strip BOM before parsing #2373

merged 1 commit into from Jul 1, 2017

Conversation

azz
Copy link
Member

@azz azz commented Jul 1, 2017

We don't reprint the BOM anyway so we may as well remove it as early as possible.

Fixes #2362

// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`bom.css 1`] = `

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a BOM here but it doesn't show up in the diff

image

@vjeux vjeux merged commit 6f98247 into prettier:master Jul 1, 2017
@Kerrick
Copy link

Kerrick commented Jul 3, 2017

Thank you so much! What's the release schedule for when this might get cut into a patched version?

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants