Add parenthesis for unusual nested ternaries #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the discussions around ternaries are for the form ```js cond1 ? elem1_if : cond2 ? elem2_if : elem_else ``` but some of them are for the form ```js cond1 ? cond2 ? elem2_if : elem2_else : elem1_else ``` which is more rare and would be good to call out by adding parenthesis. ```js cond1 ? (cond2 ? elem2_if : elem2_else) : elem1_else ``` Note that we only want parenthesis if it's written inline, otherwise the indentation is good enough to understand the flow: ```js cond1 ? cond2 ? elem2_if : elem2_else : elem1_else ```
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the discussions around ternaries are for the form
but some of them are for the form
which is more rare and would be good to call out by adding parenthesis.
Note that we only want parenthesis if it's written inline, otherwise the indentation is good enough to understand the flow: