Only break for conditionals (#1350)

We only want to break for && and ||, not for ===
prettier · Apr 19, 2017 · bae08d4 · bae08d4
1 parent 076804c
commit bae08d4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/printer.js b/src/printer.js
@@ -3205,7 +3205,7 @@ function printBinaryishExpressions(path, print, options, isNested, isInsideParen
     // in order to avoid having a small right part like -1 be on its own line.
     const parent = path.getParentNode();
     const shouldGroup =
-      !isInsideParenthesis &&
+      !(isInsideParenthesis && node.type === "LogicalExpression") &&
       parent.type !== node.type &&
       node.left.type !== node.type &&
       node.right.type !== node.type;

diff --git a/tests/binary-expressions/__snapshots__/jsfmt.spec.js.snap b/tests/binary-expressions/__snapshots__/jsfmt.spec.js.snap
@@ -61,6 +61,9 @@ if (this.hasPlugin("dynamicImports") && this.lookahead().type) {}
 if (this.hasPlugin("dynamicImports") && this.lookahead().type === tt.parenLeft) {}
 
 if (this.hasPlugin("dynamicImports") && this.lookahead().type === tt.parenLeft.right) {}
+
+if (VeryVeryVeryVeryVeryVeryVeryVeryLong === VeryVeryVeryVeryVeryVeryVeryVeryLong) {
+}
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 if (this.hasPlugin("dynamicImports") && this.lookahead().type) {
 }
@@ -77,6 +80,11 @@ if (
 ) {
 }
 
+if (
+  VeryVeryVeryVeryVeryVeryVeryVeryLong === VeryVeryVeryVeryVeryVeryVeryVeryLong
+) {
+}
+
 `;
 
 exports[`inline-object-array.js 1`] = `

diff --git a/tests/binary-expressions/if.js b/tests/binary-expressions/if.js
@@ -3,3 +3,6 @@ if (this.hasPlugin("dynamicImports") && this.lookahead().type) {}
 if (this.hasPlugin("dynamicImports") && this.lookahead().type === tt.parenLeft) {}
 
 if (this.hasPlugin("dynamicImports") && this.lookahead().type === tt.parenLeft.right) {}
+
+if (VeryVeryVeryVeryVeryVeryVeryVeryLong === VeryVeryVeryVeryVeryVeryVeryVeryLong) {
+}