Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid breaking arguments for last arg expansion (#1305)
We've had this issue since the beginning and I tagged it as 1.0 but haven't managed to fix it by then. We shouldn't allow things to break in the argument list if we are in the last argument expansion mode. It turns out that we now have all the building blocks needed to fix this: - have a special way to flag when we are printing the last argument expansion in the code that prints the argument list - have a way to remove all the softlines from the argument list Fixes #1301
- Loading branch information
Showing
3 changed files
with
56 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
export default class AddAssetHtmlPlugin { | ||
apply(compiler: WebpackCompilerType) { | ||
compiler.plugin('compilation', (compilation: WebpackCompilationType) => { | ||
compilation.plugin('html-webpack-plugin-before-html', (callback: Callback<any>) => { | ||
addAllAssetsToCompilation(this.assets, compilation, htmlPluginData, callback); | ||
}); | ||
}); | ||
} | ||
} |