Add parentheses for assignment as body of arrow (#1326)

prettier · Apr 18, 2017 · 565106d · 565106d
1 parent 652e2f9
commit 565106d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/src/fast-path.js b/src/fast-path.js
@@ -440,7 +440,7 @@ FPp.needsParens = function(assumeExpressionContext) {
 
     case "AssignmentExpression":
       if (parent.type === "ArrowFunctionExpression" && parent.body === node) {
-        return node.left.type === "ObjectPattern";
+        return true;
       } else if (
         parent.type === "ForStatement" &&
         (parent.init === node || parent.update === node)

diff --git a/tests/arrows/__snapshots__/jsfmt.spec.js.snap b/tests/arrows/__snapshots__/jsfmt.spec.js.snap
@@ -31,6 +31,8 @@ x => ({}().b);
 a::(b => c);
 a = b => c;
 a = (b?) => c;
+x => (y = z);
+x => (y += z);
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 (a => {}).length;
 typeof (() => {});
@@ -63,6 +65,8 @@ x => ({}().b);
 a::(b => c);
 a = b => c;
 a = (b?) => c;
+x => (y = z);
+x => (y += z);
 
 `;
 

diff --git a/tests/arrows/arrow_function_expression.js b/tests/arrows/arrow_function_expression.js
@@ -28,3 +28,5 @@ x => ({}().b);
 a::(b => c);
 a = b => c;
 a = (b?) => c;
+x => (y = z);
+x => (y += z);
diff --git a/tests/flow/arrays/__snapshots__/jsfmt.spec.js.snap b/tests/flow/arrays/__snapshots__/jsfmt.spec.js.snap
@@ -51,7 +51,7 @@ a[1] = "...";
 
 foo(a[1]);
 var y;
-a.forEach(x => y = x);
+a.forEach(x => (y = x));
 
 // for literals, composite element type is union of individuals
 // note: test both tuple and non-tuple inferred literals