Fix flow union params (#1251)

prettier · Apr 14, 2017 · 2078225 · 2078225
1 parent 97c662b
commit 2078225
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/src/printer.js b/src/printer.js
@@ -2302,12 +2302,32 @@ function printFunctionParams(path, print, options, expandArg) {
   }
 
   const parent = path.getParentNode();
+
+  const flowTypeAnnotations = [
+    "AnyTypeAnnotation",
+    "NullLiteralTypeAnnotation",
+    "NullableTypeAnnotation",
+    "GenericTypeAnnotation",
+    "ThisTypeAnnotation",
+    "NumberTypeAnnotation",
+    "VoidTypeAnnotation",
+    "NullTypeAnnotation",
+    "EmptyTypeAnnotation",
+    "MixedTypeAnnotation",
+    "BooleanTypeAnnotation",
+    "BooleanLiteralTypeAnnotation",
+    "StringLiteralTypeAnnotation",
+    "StringTypeAnnotation"
+  ];
+
   const isFlowShorthandWithOneArg =
     (isObjectTypePropertyAFunction(parent) ||
       isTypeAnnotationAFunction(parent) ||
       parent.type === "TypeAlias") &&
     fun[paramsField].length === 1 &&
     fun[paramsField][0].name === null &&
+    fun[paramsField][0].typeAnnotation &&
+    flowTypeAnnotations.indexOf(fun[paramsField][0].typeAnnotation.type) !== -1 &&
     !fun.rest;
 
   return concat([

diff --git a/tests/flow_return_arrow/__snapshots__/jsfmt.spec.js.snap b/tests/flow_return_arrow/__snapshots__/jsfmt.spec.js.snap
@@ -1,5 +1,12 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`issue-1249.js 1`] = `
+type Bar = ( number | string ) => number;
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+type Bar = (number | string) => number;
+
+`;
+
 exports[`parens.js 1`] = `
 const f = (): (string => string) => {};
 const f = (): (a | string => string) => {};

diff --git a/tests/flow_return_arrow/issue-1249.js b/tests/flow_return_arrow/issue-1249.js
@@ -0,0 +1 @@
+type Bar = ( number | string ) => number;