--list-different: error out there are differences #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 104 105 +1
=====================================
+ Hits 104 105 +1
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Jun 14, 2017
src/format-files.test.js
Outdated
| @@ -11,6 +11,7 @@ jest.mock('fs') | |||
|
|
|||
| beforeEach(() => { | |||
| process.stdout.write = jest.fn() | |||
| process.exitCode = 0 | |||
There was a problem hiding this comment.
Should we put this in an afterEach to avoid the process running this test from having an exit code of non-0?
There was a problem hiding this comment.
Good catch, thanks! Done.
moretti
force-pushed
the
list-different-exit-code
branch
from
ba17d0e
to
dcd9ee8
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77