Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize and improve render unit tests #1199

Merged
merged 9 commits into from Aug 29, 2018
Merged

Reorganize and improve render unit tests #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2ac65de
Initial pass at fixing up render tests
andrewiggins Jul 27, 2018
e1969b8
Break out event handling UTs into individual requirements
andrewiggins Jul 27, 2018
83fe904
Group dangerouslySetInnerHTML UTs
andrewiggins Jul 27, 2018
e1af3bf
Group style attribute tests
andrewiggins Jul 27, 2018
d766c20
Add style type switching test
andrewiggins Jul 28, 2018
cf030ac
Add test for merge argument
andrewiggins Jul 28, 2018
8e10ecb
Update TodoList render test with better test case from the original i…
andrewiggins Jul 28, 2018
f1e30cf
Move DOM attribute test to render suite
andrewiggins Aug 4, 2018
447f08d
Add test case for native event names
andrewiggins Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions test/browser/components.js
View file
Open in desktop
Expand Up @@ -151,12 +151,6 @@ describe('Components', () => {
expect(scratch.innerHTML).to.equal('');
});

// Test for #651
it('should set enumerable boolean attribute', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved this into the render.js UT file since this test doesn't actually use an components

render(<input spellcheck={false} />, scratch);
expect(scratch.firstChild.spellcheck).to.equal(false);
});

// Test for Issue #73
it('should remove orphaned elements replaced by Components', () => {
class Comp extends Component {
Expand Down