Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloneElement Typescript definition #1197

Merged
merged 3 commits into from
Aug 25, 2018
Merged

Fix cloneElement Typescript definition #1197

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e27619
Fix cloneElement Typescript definition
hiddedejong Aug 24, 2018
f48bc7e
Children argument should be a rest argument
hiddedejong Aug 25, 2018
f9d853b
Merge branch 'master' into patch-1
marvinhagemeister Aug 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/preact.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ declare namespace preact {

function render(node: ComponentChild, parent: Element | Document | ShadowRoot | DocumentFragment, mergeWith?: Element): Element;
function rerender(): void;
function cloneElement(element: JSX.Element, props: any): JSX.Element;
function cloneElement(element: JSX.Element, props: any, children?: ComponentChildren): JSX.Element;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be a rest argument like ...children


var options: {
syncComponentUpdates?: boolean;
Expand Down